Skip to content

[Impeller] the golden image tests don't catch high dpi differences #141197

@gaaclarke

Description

@gaaclarke

The golden image tests run at a scale of 1x, not high dpi. That means that if rendering is broken on high dpi, but works on 1x it won't get flagged. I think it's probably best if the golden image tests were changed to render at 2x dpi as opposed to running all the tests twice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions