Skip to content

Compiler error is erroring clang-tidy step #141130

@jmagman

Description

@jmagman

clang-tidy build:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_clang_tidy/5282/overview

Shows no issues during host_debug compilation:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1812724/overview

But there's a compilation error in clang-tidy:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1812772/overview

(I changed the WorkerJob to failOk: false) to make it show up
https://github.com/flutter/engine/blob/b232c07652ceaf1e7b701a81d76ffe285967ef17/tools/clang_tidy/lib/src/command.dart#L150

Error while processing /b/s/w/ir/cache/builder/src/flutter/impeller/toolkit/egl/surface.cc.
Suppressed 704 warnings (704 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
error: unknown argument: '-i' [clang-diagnostic-error]
error: unknown argument: '-i' [clang-diagnostic-error]
[0:06] Jobs:   0% done,   0/171 completed, 31 in progress, 139 pending,   1 failed.    
[0:06] Jobs:   1% done,   0/171 completed, 30 in progress, 139 pending,   2 failed.    
1227 warnings and 1 error generated.

Why isn't a clang-diagnostic-error showing up during clang-tidy and not compilation?

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.team-engineOwned by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions