-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Currently, the camera_android_camerax plugin wraps UseCases and fields for their initial target rotations and flash modes, e.g. https://github.com/flutter/packages/blob/36a7b99381f85e86914e82c75fc7d9038ed96cca/packages/camera/camera_android_camerax/lib/src/image_capture.dart#L51. As these UseCases are managed by the wrapped CameraX library, so are there current rotations and flash modes, so the initial target rotation and flash mode (which are literally targets and may not be achievable by CameraX) are irrelevant and should not be referenced for determining the current rotation or flash mode.
The initial target rotation and flash mode should not be saved since it should never be referenced beyond the UseCase constructors and instead, getters for the flash mode and target rotation of the UseCase like https://developer.android.com/reference/androidx/camera/core/ImageCapture#getTargetRotation(), for example, should be exposed.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status