-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listfyi-iosFor the attention of iOS platform teamFor the attention of iOS platform teamfyi-macosFor the attention of macOS platform teamFor the attention of macOS platform teamt: xcode"xcodebuild" on iOS and general Xcode project management"xcodebuild" on iOS and general Xcode project managementteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
Updated recommended settings:
iOS app:

- Asset symbol extensions
ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONSseems harmless. Not worth a migration, but we could turn it on in theflutter createtemplate. - Flutter runs on iOS 11, so we shouldn't update the target version until the minimum bumps to iOS 12. Ditto macOS
- Should not turn on quoted headers Fix all "Double-quoted include in framework header, expected angle-bracketed instead" warnings #60025
- Definitely shouldn't turn on
ENABLE_USER_SCRIPT_SANDBOXING, Flutter xcode_backend is copying files around in derived data:
error: Sandbox: rsync.samba(24872) deny(1) file-write-create /Users/magder/Library/Developer/Xcode/DerivedData/Runner-gnengnkipgqsumexkvwkdczgvrst/Build/Products/Debug-iphoneos/Flutter.framework (in target 'Runner' from project 'Runner')
error: Sandbox: dart(24844) deny(1) file-write-create /Users/magder/Library/Developer/Xcode/DerivedData/Runner-gnengnkipgqsumexkvwkdczgvrst/Build/Products/Debug-iphoneos/.last_build_id (in target 'Runner' from project 'Runner')
error: Flutter failed to write to a file at "/Users/magder/Library/Developer/Xcode/DerivedData/Runner-gnengnkipgqsumexkvwkdczgvrst/Build/Products/Debug-iphoneos/.last_build_id".
BuildIndependentTargetsInParallelshould be on in macOS and was already turned on in iOS. https://github.com/flutter/flutter/pull/125827/files#r1181817619- Dead code stripping seems good?
See #125817 and #90304 for previous cases of updating build settings for new Xcode versions.
natsuk4ze
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listfyi-iosFor the attention of iOS platform teamFor the attention of iOS platform teamfyi-macosFor the attention of macOS platform teamFor the attention of macOS platform teamt: xcode"xcodebuild" on iOS and general Xcode project management"xcodebuild" on iOS and general Xcode project managementteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
