Skip to content

[packages] Override labels no longer update on re-runs #140232

@stuartmorgan-g

Description

@stuartmorgan-g

#130076 added support for the flutter/packages workflow of adding labels that allow us to override specific checks. The intended behavior, and the way it worked when first deployed, is that if we added an override label to a PR and then re-ran the failing task, it would pass.

At some point since then the behavior has changed, and re-running is no longer picking up the current label state. Instead, the only way to get the checks to pass after adding the labels is to push a new commit to the PR. This is a major regression in functionality; the task that runs the check these labels override is explicitly designed to be fast, so instead of a workflow of "add label, re-run a fast task, PR is green a minute or two later" it's "add a label, do something that pushes a commit, which restarts all tests, potentially making it take 30+ minutes to get a landable PR".

/cc @yusuf-goog

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listpackageflutter/packages repository. See also p: labels.team-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions