Skip to content

[Impeller] come up with a better way to organize AiksTests #140106

@gaaclarke

Description

@gaaclarke

The file is getting too large and it's hard to find things. It won't scale.

Note: renaming golden tests will invalidate their history.

Possible solutions:

  1. Just break up aiks_unittests.cc based on categories (ex aiks_clipping_unittests.cc, aiks_gradient_unittests.cc)
  2. Completely get rid of aiks_unittests and allow any unittests file to be able to do the same thing so we could mix unittests and golden image tests in a file like conical_gradient_contents_unittests.cc

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions