Skip to content

[google_sign_in] Remove guava dependency  #13991

@andretietz

Description

@andretietz

This is no bugreport, more a question.

I started editing the google sign in plugin for android and figured out several problem, I would like to fix.

In order to do so, I would like to know what the getToken method is used for. According to the rest of the implementation, you can get the token out of the GoogleSignInAccount after a successful login. IMHO this method is not necessary, but I guess there's a reason for you to have it in there.

If not, I would like to remove it, since it's not really required and the dependency required (guava) is a method limit killer, since guava comes with about 15k methods

If it is needed for some reason, I created an alternative implementation without the guava dependency using android build in tools. See the PR mentioned below

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterp: google_sign_inThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions