Skip to content

labeler action failing presubmit on schema error after dependabot roll #139511

Closed

Description

@christopherfujino

I'm seeing the labeler github action fail on my PR with a schema error: https://github.com/flutter/flutter/actions/runs/7093258927/job/19306304858?pr=139510

Coincidentally, it looks like dependabot bumped our version of actions/labeler today: bbe980c

We could revert the roll, but maybe it would be easier to just fix our yaml config?

Activity

  1. drewroengoogle commented on Dec 4, 2023

    @drewroengoogle
    Contributor

    Now it's failing with a new error: https://github.com/flutter/flutter/actions/runs/7093927026/job/19308244845?pr=139510

    I believe this is similar to #129666 which was fixed by #129676, but then that PR was reverted. @ricardoamador Do you know more about why that was reverted, and if we need to reland a similar PR?

  2. drewroengoogle commented on Dec 4, 2023

    @drewroengoogle
    Contributor

    Reading more in that issue I linked, it seems like that was an accidental update to a beta version. Perhaps that logic from the beta is now in v5 of labeler?

  3. 8 remaining items

  4. keyonghan commented on Dec 5, 2023

    @keyonghan
    Contributor

    Reverted the changes as the failure was blocking all the PRs in the flutter/flutter. Something to consider when landing a fix:

    • Find out why the dependabot change was not blocked by the action execution failur.

    The reason for this is because workflow changes to github actions aren't run until after they are approved and merged. My workaround to this is that I created a fork of the labeler action updated to v5 in my own repository and fixed the yaml accordingly and confirmed it ran successfully: https://github.com/drewroengoogle/flutter/actions/runs/7102118110/job/19331743809?pr=2

    Feel free to take a look at #139564

    Do we need to land something similar to the packages repo as well? flutter/packages#5568 (comment) /cc @stuartmorgan

  5. stuartmorgan-g commented on Dec 5, 2023

    @stuartmorgan-g
    Contributor

    If v5 requires a different config, then the config will need to be updated in flutter/packages as part of re-landing v5.

  6. drewroengoogle commented on Dec 5, 2023

    @drewroengoogle
    Contributor

    flutter/packages#5580 for packages fix!

  7. github-actions commented on Dec 19, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Dec 19, 2023
  9. moved this from Verified to To be archived in [DEPRECATED] Infra Ticket Queueon Jan 31, 2024
  10. moved this from To be archived to Verified in [DEPRECATED] Infra Ticket Queueon Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listteam-infraOwned by Infrastructure team

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions