-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: leak trackingIssues and PRs related to memory leaks detected by leak_trackerIssues and PRs related to memory leaks detected by leak_trackera: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: duplicateIssue is closed as a duplicate of an existing issueIssue is closed as a duplicate of an existing issueteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team
Description
This PR adds flag to turn leak tracking on/off for flutter tests: #138653
Leak tracking is off by default till prove of its stability.
To prove leak tracker stability we need a signal about leak related failures on master. Ideally, after each PR. If it not possible, just regular execution of flutter tests with flag enabled.
This would be command to run in flutter/packages/flutter:
flutter test --dart-define=flutter_test_config.leak_tracking=true
Ideally I would like to see output of three types:
- (green) Tests passed
- (red) Tests failed and there is text
Which: contains leaks:in stdout - (yellow) Test failed without text
Which: contains leaks:in stdout
For example, it can be just email with color in the subject, like:
leak_traker report after merge of PR 123: green
I am open for any trade offs and adjustments, to make it compliant with prior art add to make it easier to configure..
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: leak trackingIssues and PRs related to memory leaks detected by leak_trackerIssues and PRs related to memory leaks detected by leak_trackera: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: duplicateIssue is closed as a duplicate of an existing issueIssue is closed as a duplicate of an existing issueteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team