Skip to content

Engine -> Framework roll blocked by new analyzer messages #138227

@zanderso

Description

@zanderso

In the roll here #138211.

The test here is now reporting different warnings: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/analyze_once_test.dart#L166

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_integration_tests_2_4/29775/overview

02:43 +35 -1: test/integration.shard/analyze_once_test.dart: working directory with errors [E]                                                                                                         
  Expected: contains 'avoid_empty_else'
    Actual: 'Analyzing flutter_project...                                    \n'
              '\n'
              '   info • The declaration \'_incrementCounter\' isn\'t referenced • lib/main.dart:30:8 • unused_element\n'
              'warning • The parameter \'onPressed\' is required • lib/main.dart:56:29 • missing_required_param\n'
              '\n'
              ''
     Which: does not contain 'avoid_empty_else'
  
  package:matcher                                      expect
  test/integration.shard/analyze_once_test.dart 411:5  assertContains
  test/integration.shard/analyze_once_test.dart 31:5   main.runCommand
  ===== asynchronous gap ===========================
  test/integration.shard/analyze_once_test.dart 188:5  main.<fn>
  

To run this test again: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart test test/integration.shard/analyze_once_test.dart -p vm --plain-name 'working directory with errors'

Commits in the Dart roll are https://dart.googlesource.com/sdk.git/+log/33307e78db2b..5075ac874117

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressiondependency: dartDart team may need to help usteam-engineOwned by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions