You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Manual Reference Counting is easy to make memory management mistake with. Objecgtive-C with Manual Reference Counting is not pleasant to work with, often scaring away contributors.
Migrate all the objective-C code to ARC will boosts Flutter's stability on iOS and making contributing to Flutter iOS embedder more efficient.
This is an umbrella issue tracks all the work needs to be done to migrate the iOS embedder to ARC:
Is there a general issue for this that include macOS?
macOS is already in ARC so I didn't create an issue for macOS. I can't think of any impact it could cause on macOS. Loop in @cbracken for might insights.
Correct -- we're already building with ARC for macOS. I can't remember if the shared code in '//flutter/platform/darwin/common' is built with ARC enabled or not.
Just realised I hadn't updated this in a while. The entire codebase, other than impeller, is migrated to ARC. ScopedBlock, scoped_nsobject, scoped_nsprotocol, etc. have all been deleted. Once impeller is migrated, I'll close this issue.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
chinmaygarde commentedon Nov 6, 2023
Is there a general issue for this that include macOS?
cyanglaz commentedon Nov 6, 2023
macOS is already in ARC so I didn't create an issue for macOS. I can't think of any impact it could cause on macOS. Loop in @cbracken for might insights.
cbracken commentedon Nov 7, 2023
Correct -- we're already building with ARC for macOS. I can't remember if the shared code in '//flutter/platform/darwin/common' is built with ARC enabled or not.
cbracken commentedon Nov 7, 2023
To answer my own question, the bulk of the common code is ARC-enabled.
https://github.com/flutter/engine/blob/cc925b0021330759e18960e1ccbd7e55dec3c375/shell/platform/darwin/common/BUILD.gn#L61-L63
[ios] introduce weak_nsobject (#47947)
[Ios] move flutter_test_ios_mrc unittests to arc (#48162)
50 remaining items
Embedder: Refactor EmbedderConfigBuilder by backend (#56598)
iOS: Eliminate FlutterEngine dealloc notification (#56650)
cbracken commentedon Nov 17, 2024
Just realised I hadn't updated this in a while. The entire codebase, other than impeller, is migrated to ARC. ScopedBlock, scoped_nsobject, scoped_nsprotocol, etc. have all been deleted. Once impeller is migrated, I'll close this issue.
iOS: Make FlutterViewController.engine a strong ref (#56663)
chinmaygarde commentedon Nov 18, 2024
Impeller is and always has been ARC only.
cbracken commentedon Nov 18, 2024
Ah that's why I didn't spot it in the targets explicitly!
Well... in that case, I think we're done. Just one more patch.
iOS,macOS: Enable ARC in flutter_cflags_objc[c] (#56685)
cbracken commentedon Nov 18, 2024
We should also make sure delegates pointers are all weak where necessary: #156222
cbracken commentedon Nov 18, 2024
DONE!
display_list: Extract backend-specific surface providers (#56711)
TestMetalContext: Use ARC-managed Metal types (#56717)
Extract backend-specific code in ShellTestPlatformView (#56722)
github-actions commentedon Dec 4, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.