-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed as not planned
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team
Description
There was a recent code change that affected CanvasKit goldens. It didn't land cleanly, so it was reverted then relanded:
- First landing: Use Layer.toImage for golden tests on CanvasKit #135249
- Revert: Reverts "Use Layer.toImage for golden tests on CanvasKit" #136860
- Relanding: Reland "Use Layer.toImage for golden tests on CanvasKit" #136918
The change affects goldens. According to Skia Gold UI the goldens changed as expected:
However, after the reland I noticed that tests were flaky for a couple of commits after the reland happened:
It's as if Skia Gold needed some time to "settle". There's a period of time during which sometimes Skia Gold would reject the new golden. For example, this build failed with "Skia Gold received an unapproved image in post-submit testing". The test generated golden was c8d9d65546ec0142469c967cd644ade0, which, according to the Skia Gold UI, is the correct SHA.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team

