Skip to content

[infra:goldens] Skia Gold "settling" after golden update #137177

@yjbanov

Description

@yjbanov

There was a recent code change that affected CanvasKit goldens. It didn't land cleanly, so it was reverted then relanded:

The change affects goldens. According to Skia Gold UI the goldens changed as expected:

Screenshot 2023-10-24 at 12 32 45 PM

However, after the reland I noticed that tests were flaky for a couple of commits after the reland happened:

Screenshot 2023-10-24 at 12 34 03 PM

It's as if Skia Gold needed some time to "settle". There's a period of time during which sometimes Skia Gold would reject the new golden. For example, this build failed with "Skia Gold received an unapproved image in post-submit testing". The test generated golden was c8d9d65546ec0142469c967cd644ade0, which, according to the Skia Gold UI, is the correct SHA.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions