-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.good first issueRelatively approachable for first-time contributorsRelatively approachable for first-time contributorsteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
I'm trying to run performance tests in Google's internal system and got the following kind of building errors:
In file included from third_party/flutter_engine/lib/ui/painting/image.cc:11:
./third_party/flutter_engine/lib/ui/painting/image_encoding_impeller.h:10:10: fatal error: 'third_party/flutter_engine/fml/status_or.h' file not found
10 | #include "third_party/flutter_engine/fml/status_or.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
sponge2/34a90d3c-29af-45ca-952f-6e9733c86612
Adding status_or.h to the internal fml/BUILD file resolves the error.
The file was added in flutter/engine#46738 which introduces this new file without adding it to BUILD.gn
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.good first issueRelatively approachable for first-time contributorsRelatively approachable for first-time contributorsteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team