Skip to content

plugin_test_ios: Clean up TestNativeUnitTests simulators after test finishes #136224

New issue
New issue
Closed
#136265
Closed
plugin_test_ios: Clean up TestNativeUnitTests simulators after test finishes#136224
#136265
Assignees
vashworth
Labels
P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.platform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team
@vashworth

Description

@vashworth
vashworth
opened on Oct 9, 2023

Test plugin_test_ios creates a simulator but does not delete it afterwards.

flutter/dev/devicelab/lib/tasks/plugin_tests.dart

Lines 265 to 276 in f52fe4f

case 'ios':
await testWithNewIOSSimulator('TestNativeUnitTests', (String deviceId) async {
if (!await runXcodeTests(
platformDirectory: path.join(rootPath, 'ios'),
destination: 'id=$deviceId',
configuration: 'Debug',
testName: 'native_plugin_unit_tests_ios',
skipCodesign: true,
)) {
throw TaskResult.failure('Platform unit tests failed');
}
});

You can see that there's a bunch of undeleted TestNativeUnitTests simulators: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8767684195411361329/+/u/list_simulators/stdout

We should delete it after the test completes.

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.platform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions