-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionfyi-ecosystemFor the attention of Ecosystem teamFor the attention of Ecosystem teamteam-iosOwned by iOS platform teamOwned by iOS platform team
Description
TL;DR: A flutter/engine iOS bug seems to have broken the flutter-packages roller, and changes are piling up.
- Deflaked broken tests: https://github.com/flutter/packages/runs/17025363571
Original message from our thread on Discord:
OK, after retrying the tasks until I got bored of doing so, there's 2 ios_platform_tests that seem legitimately broken when updating flutter master per the PR above:
- video_player: "asset videos can be initialized"
PlatformException(video_player, *** -[NSURL initFileURLWithPath:]: nil string parameter, null, null)- ios_platform_images: Failing tests:
-[UIImageExtensionTests testMultiResolutionImageUsesBest] -[UIImageExtensionTests testMultiResolutionImageUsesBest] -[UIImageExtensionTests testSingleResolutionFindsImage](It may very well be a different reasons, or an out of band change, or anything else, but I don't know how to run those tests so I can bisect them properly!)
Logs
(There's many failed builds of the roller in the flutter/packages repo.)
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionfyi-ecosystemFor the attention of Ecosystem teamFor the attention of Ecosystem teamteam-iosOwned by iOS platform teamOwned by iOS platform team