Memory Leak: NestedScrollViewState does not dispose SliverOverlapAbsorberHandle. #135246
Description
Is there an existing issue for this?
- I have searched the existing issues
- I have read the guide to filing a bug
Steps to reproduce
NestedScrollViewState does not dispose created SliverOverlapAbsorberHandle instance.
Test to reveal the leak:
testWidgetsWithLeakTracking('SliverOverlapAbsorberHandle leak', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: NestedScrollView(
floatHeaderSlivers: true,
headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) {
return <Widget>[
SliverOverlapAbsorber(
handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
sliver: const SliverAppBar.medium(
title: Text('AppBar Title'),
),
),
];
},
body: Builder(
builder: (BuildContext context) {
return CustomScrollView(
slivers: <Widget>[
SliverOverlapInjector(
handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
),
],
);
},
),
),
),
),
);
await tester.pump();
}, leakTrackingTestConfig: LeakTrackingTestConfig.debugNotDisposed());Test output
✓ SliverOverlapAbsorberHandle leak
Expected: leak free
Actual: <Instance of 'Leaks'>
Which: contains leaks:
# The text is generated by leak_tracker.
# For leak troubleshooting tips open:
# https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
notDisposed:
total: 1
objects:
SliverOverlapAbsorberHandle:
test: SliverOverlapAbsorberHandle leak
identityHashCode: 50343642
context:
start: >
#6_______flutterEventToLeakTracker_
test_widgets.dart:24
#7______MemoryAllocations.dispatchObjectEvent_
memory_allocations.dart:241
#8______MemoryAllocations.dispatchObjectCreated_
memory_allocations.dart:275
#9______ChangeNotifier.maybeDispatchObjectCreation_
change_notifier.dart:234
#10_____ChangeNotifier.addListener_
change_notifier.dart:274
#11_____RenderSliverOverlapInjector.attach_
nested_scroll_view.dart:1934
#12_____RenderObject.adoptChild_
object.dart:1812
#13_____ContainerRenderObjectMixin.insert_
object.dart:4224
#14_____MultiChildRenderObjectElement.insertRenderObjectChild_
framework.dart:6720
#15______ViewportElement.insertRenderObjectChild_
viewport.dart:266
#16_____RenderObjectElement.attachRenderObject_
framework.dart:6479
#17_____RenderObjectElement.mount_
framework.dart:6346
#18_____SingleChildRenderObjectElement.mount_
framework.dart:6645
#19_____Element.inflateWidget_
framework.dart:4326
#20_____MultiChildRenderObjectElement.inflateWidget_
framework.dart:6781
#21_____MultiChildRenderObjectElement.mount_
framework.dart:6793
#22______ViewportElement.mount_
viewport.dart:225
#23_____Element.inflateWidget_
framework.dart:4326
#24_____Element.updateChild_
framework.dart:3837
#25_____SingleChildRenderObjectElement.mount_
framework.dart:6646
#26_____Element.inflateWidget_
framework.dart:4326
#27_____Element.updateChild_
framework.dart:3837
#28_____SingleChildRenderObjectElement.mount_
framework.dart:6646
#29_____Element.inflateWidget_
framework.dart:4326Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.14.0-14.0.pre.423, on macOS 13.0.1 22A400 darwin-arm64, locale en-GB)
• Flutter version 3.14.0-14.0.pre.423 on channel master at /Users/ksokolovskyi/dev/flutter_master
• Upstream repository [email protected]:ksokolovskyi/flutter.git
• FLUTTER_GIT_URL = [email protected]:ksokolovskyi/flutter.git
• Framework revision 30a9f99bc8 (17 minutes ago), 2023-09-21 11:49:29 -0700
• Engine revision 78c1ad249b
• Dart version 3.2.0 (build 3.2.0-187.0.dev)
• DevTools version 2.28.0-dev.12
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
• Android SDK at /Users/ksokolovskyi/Library/Android/sdk
• Platform android-34, build-tools 33.0.1
• ANDROID_HOME = /Users/ksokolovskyi/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E300c
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
[✓] IntelliJ IDEA Community Edition (version 2023.2)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.82.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.72.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-arm64 • macOS 13.0.1 22A400 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 116.0.5845.187
[✓] Network resources
• All expected network resources are available.
• No issues found!