-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#46110Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team
Description
Blocks #134969.
I'm requesting help if anyone could use a simple~ish task to work on in the background.
@@ -46,7 +46,7 @@ class DlBlurMaskFilter final : public DlMaskFilter {
: style_(style), sigma_(sigma), respect_ctm_(respect_ctm) {}
DlBlurMaskFilter(const DlBlurMaskFilter& filter)
: DlBlurMaskFilter(filter.style_, filter.sigma_, filter.respect_ctm_) {}
- DlBlurMaskFilter(const DlBlurMaskFilter* filter)
+ explicit DlBlurMaskFilter(const DlBlurMaskFilter* filter)
: DlBlurMaskFilter(filter->style_, filter->sigma_, filter->respect_ctm_) {
}... and then changing the rest of the repo to use DlBlurMaskFilter(filter) explicitly.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team