-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#47763Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
The locking without static analysis makes me nervous. I suspect we didn't use the
IPLR_GUARDED_BYand friends because we don't have static thread safety analysis around condition variable. This should be easy enough to add support for. Can we file a followup bug for it?
So, this is that bug!
I also mentioned I'd personally prefer to just use absl if possible (#134741), but that's not necessarily a blocker.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team