Skip to content

[Impeller] AiksInspector leaks allocated textures. #134748

@matanlurey

Description

@matanlurey

The fix:

// aiks_playground_inspector.cc

+ void AiksInspector::HackResetDueToTextureLeaks() {
+   last_picture_.reset();
+ }
// aiks_playground.cc

+ void AiksPlayground::TearDown() {
+   inspector_.HackResetDueToTextureLeaks();
+   PlaygroundTest::TearDown();
+ }

@jonahwilliams commentary:

I don't think this code is running in the right order. It might be torn down after we run shutdown of the context

because the dtors are running after shutdown

but shutdown is what tries to flush the fence waiter/resource manager

I want to fix this, but after some more pressing issues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions