Memory Leak: ListWheelScrollView does not dispose fallback FixedExtentScrollController #134724
Description
Is there an existing issue for this?
- I have searched the existing issues
- I have read the guide to filing a bug
Steps to reproduce
When no ScrollController is passed into ListWheelScrollView it creates a fallback one. This controller is not getting disposed.
Test to reveal the leak:
testWidgetsWithLeakTracking('ListWheelScrollView leak', (WidgetTester tester) async {
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: ListWheelScrollView(
itemExtent: 10.0,
children: <Widget>[Container()],
),
),
);
await tester.pump();
}, leakTrackingTestConfig: LeakTrackingTestConfig.debugNotDisposed());Test output
Expected: leak free
Actual: <Instance of 'Leaks'>
Which: contains leaks:
# The text is generated by leak_tracker.
# For leak troubleshooting tips open:
# https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
notDisposed:
total: 1
objects:
FixedExtentScrollController:
test: ListWheelScrollView leak
identityHashCode: 124903725
context:
start: >
#6_______flutterEventToLeakTracker_(package:leak_tracker_flutter_testing/src/test_widgets.dart:24:23)
#7______MemoryAllocations.dispatchObjectEvent_(package:flutter/src/foundation/memory_allocations.dart:238:23)
#8______MemoryAllocations.dispatchObjectCreated_(package:flutter/src/foundation/memory_allocations.dart:272:5)
#9______ChangeNotifier.maybeDispatchObjectCreation_(package:flutter/src/foundation/change_notifier.dart:234:34)
#10_____new_ScrollController_(package:flutter/src/widgets/scroll_controller.dart:68:7)
#11_____new_FixedExtentScrollController_(package:flutter/src/widgets/list_wheel_scroll_view.dart)
#12______ListWheelScrollViewState.initState_(package:flutter/src/widgets/list_wheel_scroll_view.dart:717:45)
#13_____StatefulElement._firstBuild_(package:flutter/src/widgets/framework.dart:5605:55)
#14_____ComponentElement.mount_(package:flutter/src/widgets/framework.dart:5450:5)
#15_____Element.inflateWidget_(package:flutter/src/widgets/framework.dart:4329:16)
#16_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3840:18)
#17_____ComponentElement.performRebuild_(package:flutter/src/widgets/framework.dart:5499:16)
#18_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#19_____ComponentElement._firstBuild_(package:flutter/src/widgets/framework.dart:5456:5)
#20_____ComponentElement.mount_(package:flutter/src/widgets/framework.dart:5450:5)
#21_____Element.inflateWidget_(package:flutter/src/widgets/framework.dart:4329:16)
#22_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3834:20)
#23_____ComponentElement.performRebuild_(package:flutter/src/widgets/framework.dart:5499:16)
#24_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#25_____ProxyElement.update_(package:flutter/src/widgets/framework.dart:5803:5)
#26_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3818:15)
#27_____ComponentElement.performRebuild_(package:flutter/src/widgets/framework.dart:5499:16)
#28_____StatefulElement.performRebuild_(package:flutter/src/widgets/framework.dart:5637:11)
#29_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#30_____StatefulElement.update_(package:flutter/src/widgets/framework.dart:5660:5)
#31_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3818:15)
#32_____ComponentElement.performRebuild_(package:flutter/src/widgets/framework.dart:5499:16)
#33_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#34_____ProxyElement.update_(package:flutter/src/widgets/framework.dart:5803:5)
#35_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3818:15)
#36_____ComponentElement.performRebuild_(package:flutter/src/widgets/framework.dart:5499:16)
#37_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#38_____ProxyElement.update_(package:flutter/src/widgets/framework.dart:5803:5)
#39_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3818:15)
#40______RawViewElement._updateChild_(package:flutter/src/widgets/view.dart:289:16)
#41______RawViewElement.update_(package:flutter/src/widgets/view.dart:376:5)
#42_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3818:15)
#43_____ComponentElement.performRebuild_(package:flutter/src/widgets/framework.dart:5499:16)
#44_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#45_____StatelessElement.update_(package:flutter/src/widgets/framework.dart:5550:5)
#46_____Element.updateChild_(package:flutter/src/widgets/framework.dart:3818:15)
#47_____RootElement._rebuild_(package:flutter/src/widgets/binding.dart:1334:16)
#48_____RootElement.update_(package:flutter/src/widgets/binding.dart:1312:5)
#49_____RootElement.performRebuild_(package:flutter/src/widgets/binding.dart:1326:7)
#50_____Element.rebuild_(package:flutter/src/widgets/framework.dart:5190:7)
#51_____BuildOwner.buildScope_(package:flutter/src/widgets/framework.dart:2898:19)
#52_____AutomatedTestWidgetsFlutterBinding.drawFrame_(package:flutter_test/src/binding.dart:1409:19)
#53_____RendererBinding._handlePersistentFrameCallback_(package:flutter/src/rendering/binding.dart:457:5)
#54_____SchedulerBinding._invokeFrameCallback_(package:flutter/src/scheduler/binding.dart:1325:15)
#55_____SchedulerBinding.handleDrawFrame_(package:flutter/src/scheduler/binding.dart:1255:9)
#56_____AutomatedTestWidgetsFlutterBinding.pump.<anonymous_closure>_(package:flutter_test/src/binding.dart:1264:9)
#57______rootRun_(dart:async/zone.dart:1399:13)
#58______CustomZone.run_(dart:async/zone.dart:1301:19)
#59_____TestAsyncUtils.guard_(package:flutter_test/src/test_async_utils.dart:71:41)
#60_____AutomatedTestWidgetsFlutterBinding.pump_(package:flutter_test/src/binding.dart:1251:27)
#61_____WidgetTester.pumpWidget.<anonymous_closure>_(package:flutter_test/src/widget_tester.dart:578:22)
#62______rootRun_(dart:async/zone.dart:1399:13)
#63______CustomZone.run_(dart:async/zone.dart:1301:19)
#64_____TestAsyncUtils.guard_(package:flutter_test/src/test_async_utils.dart:71:41)
#65_____WidgetTester.pumpWidget_(package:flutter_test/src/widget_tester.dart:575:27)
#66_____main.<anonymous_closure>_(file:///Users/ksokolovskyi/dev/flutter_master/packages/flutter/test/widgets/list_wheel_scroll_view_test.dart:42:16)
#67_____testWidgetsWithLeakTracking.wrappedCallBack_(package:leak_tracker_flutter_testing/src/test_widgets.dart:126:19)
#68_____testWidgets.<anonymous_closure>.<anonymous_closure>_(package:flutter_test/src/widget_tester.dart:168:29)
<asynchronous_suspension>
#69_____TestWidgetsFlutterBinding._runTestBody_(package:flutter_test/src/binding.dart:1013:5)
<asynchronous_suspension>
#70_____StackZoneSpecification._registerCallback.<anonymous_closure>_(package:stack_trace/src/stack_zone_specification.dart:114:42)
<asynchronous_suspension>
package:matcher expect
package:flutter_test/src/widget_tester.dart 458:18 expect
package:leak_tracker_flutter_testing/src/test_widgets.dart 81:5 _tearDownTestingWithLeakTracking
===== asynchronous gap ===========================
dart:async _CustomZone.registerBinaryCallback
package:leak_tracker_flutter_testing/src/test_widgets.dart 59:9 configureLeakTrackingTearDown.<fn>Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.14.0-14.0.pre.290, on macOS 13.0.1 22A400 darwin-arm64, locale en-GB)
• Flutter version 3.14.0-14.0.pre.290 on channel master at /Users/ksokolovskyi/dev/flutter_master
• Upstream repository [email protected]:ksokolovskyi/flutter.git
• FLUTTER_GIT_URL = [email protected]:ksokolovskyi/flutter.git
• Framework revision 77a5a5d3a8 (5 hours ago), 2023-09-14 08:42:41 +0200
• Engine revision cd90cc8469
• Dart version 3.2.0 (build 3.2.0-140.0.dev)
• DevTools version 2.27.0
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
• Android SDK at /Users/ksokolovskyi/Library/Android/sdk
• Platform android-33, build-tools 33.0.1
• ANDROID_HOME = /Users/ksokolovskyi/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E300c
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
[✓] IntelliJ IDEA Community Edition (version 2023.2)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.82.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.72.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-arm64 • macOS 13.0.1 22A400 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 116.0.5845.187
[✓] Network resources
• All expected network resources are available.
• No issues found!