-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
We have a lot of code in FlutterViewController that is getting size information from the Flutter view, but scale from the UIScreen. This adds complexity, especially with the deprecation of mainScreen, and it's not at all clear to me what we are involving the screen at all; if we want the Flutter view's scale factor, which I believe is the case, we should use the view's contentScaleFactor.
I don't know for certain that there isn't some subtle reason this is better, vs just an API oversight, but we should investigate to see and simplify the code if it's not necessary to do it this way.
amrgetment and guilherme-francisco
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtriaged-iosTriaged by iOS platform teamTriaged by iOS platform team