Skip to content

[flutter_tools] output format animations test is flaky #133266

@christopherfujino

Description

@christopherfujino

tool_tests-general-linux

https://cirrus-ci.com/task/6419280829349888?logs=main#L1140

01:01 +2234 ~4 -1: test/general.shard/base/logger_test.dart: Output format Animations are disabled when, uh, disabled. [E]                                                                             
  Expected: [
              'po                                                                   0ms',
              'ta                                                              ',
              'ta                                                                   0ms',
              ''
            ]
    Actual: [
              'po                                                                   0ms',
              'ta                                                              ',
              'ta                                                                   2ms',
              ''
            ]
     Which: at location [2] is 'ta                                                                   2ms' instead of 'ta                                                                   0ms'
  package:matcher                                  expect
  test/general.shard/base/logger_test.dart 1311:7  main.<fn>.<fn>
  dart:async                                       runZoned
  test/src/common.dart 208:14                      testWithoutContext.<fn>
  test/src/common.dart 177:18                      test.<fn>

I'm thinking we should either use a FakeClock here, or make the pattern matcher more general

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-toolOwned by Flutter Tool team

    Type

    No type

    Projects

    Status

    Test flakes

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions