-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
For example, imagine I wanted to write a test that shows the following bug: #126673.
I'd (as far as I understand it) have to write this in the framework layer (flutter/flutter) in order to get full tooling support, and in the case of validating that we're drawing the "right kind of lines", probably golden-file tests. Within flutter/engine, there are two other kinds of tests that don't seem to meet my needs:
aiks_unittests.cc, which runs on the Impeller backend with a custom harness, but doesn't let me reuse existing tests and will be harder to catch Skia <> Impeller fidelity issues.canvas_test.dart, which only runs on the software backend (which Impeller doesn't support if I understand correctly).
Related issues:
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team