Skip to content

Test fails based on time taken rather than testing the actual condition #133215

@flar

Description

@flar

In this PR: #132239

A test was added that looks for output that it expects to have "0ms" as the run time. That is not a reliable condition on test hosts and presumably doesn't actually test that the behavior was actually disabled, just that it doesn't take "much" time.

A failure on this test can derail an engine roll as seen here: https://cirrus-ci.com/task/5417897460236288?logs=main#L1130

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions