-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue
Description
Issue Link
Commit Hash
376993f
Target
stable
PR Link
Changelog Description
Fixes an issue with tree shaking fonts that do not contain a space glyph.
Impacted Users
Flutter Web apps that have custom fonts that do not contain a space glyph
Impact Description
The flutter tool fails out with an error when attempting to compile an app that uses a custom icon font that does not contain a space.
Workaround
The user can pass --no-tree-shake-icons to prevent icon tree shaking, which will allow the flutter tool to complete the build process. However, it skips icon tree shaking, which bloats the payload size of their font files.
Risk
low
Test Coverage
yes
Validation Steps
New integration tests have been added that ensure that the font-subset tool can handle optional characters. Subsequent testing will happen with the framework change, which will follow.
Metadata
Metadata
Assignees
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue