Skip to content

[CP] Allow optional codepoints to be expressed to the font subset generator #132878

@eyebrowsoffire

Description

@eyebrowsoffire

Issue Link

#132711

Commit Hash

376993f

Target

stable

PR Link

flutter/engine#44869

Changelog Description

Fixes an issue with tree shaking fonts that do not contain a space glyph.

Impacted Users

Flutter Web apps that have custom fonts that do not contain a space glyph

Impact Description

The flutter tool fails out with an error when attempting to compile an app that uses a custom icon font that does not contain a space.

Workaround

The user can pass --no-tree-shake-icons to prevent icon tree shaking, which will allow the flutter tool to complete the build process. However, it skips icon tree shaking, which bloats the payload size of their font files.

Risk

low

Test Coverage

yes

Validation Steps

New integration tests have been added that ensure that the font-subset tool can handle optional characters. Subsequent testing will happen with the framework change, which will follow.

Metadata

Metadata

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions