Skip to content

[Impeller] Command::viewport and Command::scissor are only used in tests. #132781

New issue
New issue
Closed as not planned
Closed as not planned
[Impeller] Command::viewport and Command::scissor are only used in tests.#132781
Labels
P3Issues that are less important to the Flutter projecta: tests"flutter test", flutter_test, or one of our testse: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team
@dnfield

Description

@dnfield
dnfield
opened on Aug 17, 2023

These objects are only ever set for the ImGui backend used in playgrounds:

https://github.com/flutter/engine/blob/9fae689d10a9fc7615b9b185172b1bed5c8d40a1/impeller/playground/imgui/imgui_impl_impeller.cc#L245-L246

They contribute sizeof(Rect) * 2 to the size of command objects. We should remove them if they're really only useful for ImGui, or use them if they'd be useful elsewhere.

@bdero WDYT?

@gaaclarke fyi

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: tests"flutter test", flutter_test, or one of our testse: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions