-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
This is a follow up to #132592, to ensure it doesn't happen again.
Before we extract the Dart SDK zip archive on windows, we move the existing output to a backup, and then extract zip to previous location of the old one. However, when a new file was added to this archive (LICENSE.dart_sdk_archive.md) but the powershell file to extract it wasn't updated, the 7zip sub-process that was spawned would prompt the user what they wanted to do about the conflict, but the powershell script would never surface this prompt to the user.
This was fixed by special-casing this file. However, we need a more robust solution to prevent this from happening again.
loic-sharma
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team