Skip to content

[Impeller] entity_pass.cc gives Clang tools trouble. #132417

@chinmaygarde

Description

@chinmaygarde

entity_pass.cc has been excluded from clang-tidy runs in flutter/engine#44495 by @zanderso and @bdero has also noticed issues with ClangD using the same.

This may be because of the inclusion of impeller::ContentContext which makes heavy use of templates. We could sidestep these by moving template instantiations into content_context.cc.

But, the root cause of this is still unknown and this issue tracks making the developer experience better.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work liste: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions