-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Closed
Copy link
Labels
c: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamOwned by Flutter Tool team
Description
Status: WIP. There are enough PRs out right now where I'm focusing on getting them landed/sticking before moving forward.
This is a follow-up to #132180 (comment).
As of #132180, --local-engine-host is optional, and if omitted, falls back to trying to derive the host.
We'd like to make this explicit instead, so:
- Announce the changes to the flutter tool to appropriate channels and wait a reasonable duration for feedback
- Update the
devicelab. - Update the
glfwexamples and related examples inexamples/*gl*/**. - Update the
tool_backend.dartand related scripts influtter_tools/bin/*. - Update
flutter.groovyand related. - Update the
dart_roll_helper.py. - Update the web engine
web_ui/dev/build.dartand related files inweb_ui/dev/*. Updateflutter_gbd.- Doesn't appear to need any changes, uses the device engine only.
- Update
dev/bots/test.dart. - Update
build_linux.dart. - Update
xcode_build_settings.dart. - Update
build_windows.dart. - Try a CI run where
--local-engine-hostis required, and fix CI bots, tests, and bash scripts that aren't using it - Replace the warning message with
throwToolExitand delete_getHostEngineBasenameand friends
Metadata
Metadata
Assignees
Labels
c: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamOwned by Flutter Tool team