Skip to content

popup_menu_test.dart lacks default icon color tests. #132050

@TahaTesser

Description

@TahaTesser

Is there an existing issue for this?

Use case

If you modify some default colors, there are no tests that fail.

For instance, replace the default color for the popup menu item button and run the tests

color: widget.color ?? iconTheme.color,

      iconSize: widget.iconSize ?? iconTheme.size,
      color: widget.color ?? const Color(0xffffff00),
flutter test test/material/popup_menu_test.dart
00:05 +58: All tests passed!

Proposal

Add missing default color tests

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages team

Type

No type

Projects

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions