-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#44434Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallyr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-androidOwned by Android platform teamOwned by Android platform team
Description
Is there an existing issue for this?
- I have searched the existing issues
- I have read the guide to filing a bug
Use case
flutter/engine#41982 fixes BasicMessageChannel.resizeChannelBuffer which was broken.
The fix was based on the existing implementation which relies on a deprecated format (see flutter/engine#41982 (comment)).
Proposal
Replace BasicMessageChannel.resizeChannelBuffer implementation to rely on the expected and more efficient format.
While doing so, consider providing a similar helper for the overflow control message, see https://github.com/flutter/engine/blob/5b47c05770609a6f10d84e624c43c94bc7b4de4d/lib/ui/channel_buffers.dart#L447-L458
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-androidAndroid applications specificallyAndroid applications specificallyr: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-androidOwned by Android platform teamOwned by Android platform team
Type
Projects
Status
Done (PR merged)