Skip to content

Android - BasicMessageChannel.resizeChannelBuffer should use a non deprecated format and be more efficient #132048

@bleroux

Description

@bleroux

Is there an existing issue for this?

Use case

flutter/engine#41982 fixes BasicMessageChannel.resizeChannelBuffer which was broken.
The fix was based on the existing implementation which relies on a deprecated format (see flutter/engine#41982 (comment)).

Proposal

Replace BasicMessageChannel.resizeChannelBuffer implementation to rely on the expected and more efficient format.

While doing so, consider providing a similar helper for the overflow control message, see https://github.com/flutter/engine/blob/5b47c05770609a6f10d84e624c43c94bc7b4de4d/lib/ui/channel_buffers.dart#L447-L458

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.platform-androidAndroid applications specificallyr: fixedIssue is closed as already fixed in a newer versionteam-androidOwned by Android platform team

Type

No type

Projects

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions