-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#55012Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: platform-viewsEmbedding Android/iOS views in Flutter appsEmbedding Android/iOS views in Flutter appsa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testse: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Today these use --enable-software-rendering, which is not supported in impeller, so they have not actually been testing impeller. I'm going to be disabling them as part of fixing #131887, but they should get re-enabled to get coverage.
One thing that is not clear is how significant pixel differences will be if we enable impeller.
As part of re-enabling them, it may be worthwhile to see if we can upload the images to gold rather than doing the comparisons as part of the test harness.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: platform-viewsEmbedding Android/iOS views in Flutter appsEmbedding Android/iOS views in Flutter appsa: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testse: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team