-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecta: multi windowIssues related to multi window supportIssues related to multi window supportc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Description
SingletonFlutterWindow window is a global variable that represents the only window of a single-view Flutter app. Since flutter/engine#42991, this variable is a normal FlutterView with ID of _implicitViewId!, which will crash the app if the implicit view is disabled. We must address this issue by the end of phase 2 when the runners are allowed to disable the implicit view.
Part of:
Goal:
- Using
windowin whatever ways should not trigger errors when the implicit view is disabled. - Instead of mapping
windowto an arbitrary existing view, which should provide expected behaviors: thewindowcorresponds to the implicit view, such asFlutterEngine.viewController.
Conclusion:
- Using
windowwhen the implicit view is disabled should be no-ops. - All methods that accept a
FlutterViewshould check whether the view refers to a disabled implicit view.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecta: multi windowIssues related to multi window supportIssues related to multi window supportc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Type
Projects
Status
Backlog