-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Closed
Copy link
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue
Description
Issue Link
Commit Hash
Target
beta
PR Link
Changelog Description
Apps that use WidgetSpans in text widgets may throw an assertion when the text scale factor is set to certain values.
Impacted Users
WidgetSpan users
Impact Description
Apps that use WidgetSpans in text widgets may throw an assertion when the text scale factor is set to certain values, due to floating point precision.
Workaround
No easy workaround available
Risk
low
Test Coverage
yes
Validation Steps
Follow the repro steps in #130588, or run this test: https://github.com/flutter/flutter/pull/130648/files#diff-9fccc94ba0e90a5fb4c5b90761fe59995a5cf7bad0d580c6c2ff3cceafb495e5
Metadata
Metadata
Assignees
Labels
cp: approvedApproved cherry-pick requestApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.Cherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queueCherry-picks in the review queue