Skip to content

[CP] Allow OverlayPortal to be added/removed from the tree in a layout callback #131002

@LongCatIsLooong

Description

@LongCatIsLooong

Issue Link

#130668

Commit Hash

bf4d659

Target

beta

PR Link

#130670

Changelog Description

The application asserts when a Tooltip is opened/closed in a layout callback, typically in a LayoutBuilder or when scrolled away in a ListView.

Impacted Users

Tooltip widget users, especially those use it in a ListView

Impact Description

App asserts in debug mode

Workaround

No easy workaround.

Risk

low

Test Coverage

yes

Validation Steps

Either follow the steps provided in #130668, or run the test added in the fix: https://github.com/flutter/flutter/pull/130670/files#diff-d078821c55cd4390761f5928348ab73b271c76edb7c9a440af7edb08ad6896d7

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions