-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Description
At one point there was an issue with Skia bounds of shadow operations and so the code was sprinkled with calls to draw a transparent rect of the proper bounds to work around the issue.
Now that we are using DisplayList internally instead of SkPictureRecorder, the bounds are correct without the workarounds (also, it is likely that Skia fixed that bug a long time ago and so it was already obsolete even before DisplayList). These code snippets should be removed.
One example:
| // The drawShadow call doesn't add the region of the shadow to the |
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team