Skip to content

Potentially obsolete use of transparent rectangles to fix bounds issues #130737

@flar

Description

@flar

At one point there was an issue with Skia bounds of shadow operations and so the code was sprinkled with calls to draw a transparent rect of the proper bounds to work around the issue.

Now that we are using DisplayList internally instead of SkPictureRecorder, the bounds are correct without the workarounds (also, it is likely that Skia fixed that bug a long time ago and so it was already obsolete even before DisplayList). These code snippets should be removed.

One example:

// The drawShadow call doesn't add the region of the shadow to the

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listframeworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions