Skip to content

Undue breaking change in buildTransitions breaks dependencies #130062

@Andrflor

Description

@Andrflor

Is there an existing issue for this?

Steps to reproduce

Have any package that use buildTransations (like GetX for example)
Have flutter after aaaea51
flutter run

Expected results

Should compile and run

Actual results

Won't compile no more

Problem source

The commit aaaea51 introduced an unnecessary breaking change in the buildTransitions function signature. This breaking share will break any lib, (like here the very popular GetX) in all versions that use the function because of the unnecessary breaking change.

Could that added parameter be made optional so apps will compile again without having to modify all the packages that are using buildTransitions?
extact modification reference

Logs

ERROR: ../../.pub-cache/git/getx-c826fa0539ceb8029dde54bd20b832374c6c4551/lib/get_navigation/src/routes/get_transition_mixin.dart:608:57: Error: Too few positional arguments: 6 required, 5 given.
ERROR:           return PageTransitionsTheme().buildTransitions(
ERROR:                                                         ^
ERROR: ../../.pub-cache/git/getx-c826fa0539ceb8029dde54bd20b832374c6c4551/lib/get_navigation/src/routes/get_transition_mixin.dart:644:57: Error: Too few positional arguments: 6 required, 5 given.
ERROR:           return PageTransitionsTheme().buildTransitions(
ERROR:                                                         ^
ERROR: Target kernel_snapshot failed: Exception

Flutter Doctor output

NA

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: API breakBackwards-incompatible API changesd: api docsIssues with https://api.flutter.dev/f: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions