-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#5787Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team
Description
The method is currently defined as clearAuthCache({String? token}), but that appears to be a mistake from the NNBD migration; on the app-facing side, it's always called with a force-unwrapped token argument, and in the Android implementation it's required to be non-null. (I noticed this while migrating Android to Pigeon, but that behavior predates the Pigeon version).
Given that both ends are forcing it to be non-null, it's clear that this should have been {required String token} instead. We should deprecate the incorrect one, and create a new replacement with the correct nullability.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.p: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem teamTriaged by Ecosystem team