Skip to content

[google_sign_in] clearAuthCache platform interface is incorrect #129717

@stuartmorgan-g

Description

@stuartmorgan-g

The method is currently defined as clearAuthCache({String? token}), but that appears to be a mistake from the NNBD migration; on the app-facing side, it's always called with a force-unwrapped token argument, and in the Android implementation it's required to be non-null. (I noticed this while migrating Android to Pigeon, but that behavior predates the Pigeon version).

Given that both ends are forcing it to be non-null, it's clear that this should have been {required String token} instead. We should deprecate the incorrect one, and create a new replacement with the correct nullability.

Metadata

Metadata

Labels

P1High-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.p: google_sign_inThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions