Skip to content

Change in API docs samples did not trigger tests in presubmit #129390

@Piinks

Description

@Piinks

Found in #129381

This small change to an API doc sample did not end up executing the sample code tests in presubmit.

Related to #129389, I was looking into why gold did not run for the PR and discovered that on top of that edge case the tests had not actually run either.

https://flutter-gold.skia.org/changelists shows no golden file tests were run for that PR, which would have happened if the tests had run at all.

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions