Skip to content

API docs edge case in flutter gold logic #129389

@Piinks

Description

@Piinks

Found in #129381

The flutter gold check only runs on PRs that are running golden file tests - or so we thought. 🕵️

The way the check determines this is by checking the already running checks on a PR. If the framework test shards or web test shards are running, flutter gold adds itself to the queue:

https://github.com/flutter/cocoon/blob/26515729f2afdf0a77b03c9bdcd06824cc4b0436/app_dart/lib/src/request_handlers/push_gold_status_to_github.dart#L122

In #129381, we found that the API docs are not accounted for by this. The API docs tests run on a different shard (I think misc?) and so flutter gold was not triggered.

This would have broken the tree if @HansMuller had not known a golden file change was expected. The PR could have landed, the new image would have shown up in post submit as untriaged, and the tree would go red.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/d: examplesSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions