-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/cocoon
#2860Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/d: examplesSample code and demosSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure teamOwned by Infrastructure team
Description
Found in #129381
The flutter gold check only runs on PRs that are running golden file tests - or so we thought. 🕵️
The way the check determines this is by checking the already running checks on a PR. If the framework test shards or web test shards are running, flutter gold adds itself to the queue:
In #129381, we found that the API docs are not accounted for by this. The API docs tests run on a different shard (I think misc?) and so flutter gold was not triggered.
This would have broken the tree if @HansMuller had not known a golden file change was expected. The PR could have landed, the new image would have shown up in post submit as untriaged, and the tree would go red.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.d: api docsIssues with https://api.flutter.dev/Issues with https://api.flutter.dev/d: examplesSample code and demosSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure teamOwned by Infrastructure team