-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#54450Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Background
flutter/engine#36123 adds tests to verify formatting pre-push checks work. The Java format check was disabled as the Java dependency isn't available on all platforms: https://github.com/flutter/engine/blob/22401c23e94c6e4ffeb58c171b0d151a614c60e9/DEPS#L767
Solution
If the Java dependency is available, enable the Java format check unit tests: https://github.com/flutter/engine/blob/08aaa88bf67fcd5a18d4309d89c1e940a544e49a/ci/test/format_test.dart#L190-L192
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team