-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
We have some tests that use @TestOn('browser') (or 'chrome', which maybe is a bug?), but in CI we only run Dart unit tests in a browser if they are part of a web plugin implementation. That means we're missing some test coverage for, e.g., cross_file.
We should scan for @TestOn in unit test folders, and if we find any, ensure that we are running tests in the appropriate mode. I believe that could just replace our current plugin-based logic, but we'll need to verify that.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.