Skip to content

PopupMenu Material 3 tokens #128877

@TahaTesser

Description

@TahaTesser

Is there an existing issue for this?

Use case

https://github.com/flutter/flutter/blob/master/dev/tools/gen_defaults/data/menu.json seems to be incomplete.

For some reason, I had to hardcode this label style for the popup menu a year ago.

final TextStyle style = _textTheme.labelLarge!;

When looking into #128576, this issue was rediscovered.

https://m3.material.io/components/menus/specs mentions the label large text style.
However, this isn't available in menu tokens or list item tokens.
Screenshot 2023-06-14 at 17 59 03

I can see such a token in Compose https://github.com/androidx/androidx/blob/androidx-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/MenuTokens.kt

Proposal

If the tokens are missing, add them.

or

Use the list item label token and update M3 web specs to reflect the same.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.team-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions