Bring back fade transition to Material page transition #12877

Activity

1. xster

   added

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   on Nov 4, 2017
2. eseidelGoogle commented on Nov 6, 2017

   

   eseidelGoogle

   on Nov 6, 2017

   Contributor

   More actions

   @chinmaygarde had some planned compositor optimizations. You might ask him if he has any planned which would make this easier.
3. Hixie

   added

   c: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   on Nov 7, 2017
4. Hixie

   added this to the 4: Next milestoneThis milestone has been deleted milestone on Nov 7, 2017
5. Hixie

   added

   c: regressionIt was better in the past than it is nowIt was better in the past than it is now

   on Nov 7, 2017
6. passsy

   added a commit that references this issue on Nov 16, 2017

   Reenable fade transition for Material page transition

   ...

   This issue will close once commit 11cd9e4 is merged into the 'master' branch.

   11cd9e4
7. Hixie

   closed this as completedin #13048on Nov 22, 2017
8. Hixie

   added a commit that references this issue on Nov 22, 2017

   Reenable fade transition for Material page transition (#13048)

   ...

   This issue will close once commit e73d406 is merged into the 'master' branch.

   e73d406
9. passsy commented on Nov 23, 2017

   

   passsy

   on Nov 23, 2017

   Contributor

   More actions

   @Hixie please reopen
10. xster commented on Nov 23, 2017

    

    xster

    on Nov 23, 2017

    ContributorAuthor

    More actions

    Reopening since it was reverted.

    Might help doing #13173 first.
11. xster

    reopened this on Nov 23, 2017
12. brianegan commented on Dec 14, 2017

    

    brianegan

    on Dec 14, 2017

    Last edited by brianegan

    Contributor

    More actions

    Hey all -- know there's a ton on your plate, but just wondering if there been any movement on this one? I feel like this is a pretty visible / janky bug to expose to users... all "back" transitions look really rough.

    👍React with 👍3Reacted by Pascal Welsch, Manpreet Singh Matharu and luccascorrea
13. sethladd commented on Dec 14, 2017

    

    sethladd

    on Dec 14, 2017

    Contributor

    More actions

    I noticed that on Android at least, the back animation (the material sheet sliding down) seems to simply disappear half-way through the animation down. I'm assuming this is a bug, because it used to be very beautiful :)

    👍React with 👍5Reacted by Harry Turton, Ivascu Adrian, Thomas Quercia, Cretezy and Itay Ganor
14. 2 remaining items

    Load more
15. Hixie

    added

    waiting for PR to land (fixed)A fix is in flightA fix is in flight

    on Dec 20, 2017
16. Hixie

    closed this as completedin #13680on Dec 20, 2017
17. Hixie

    added a commit that references this issue on Dec 20, 2017

    Reenable fade transition for Material page transition (#13048) (#13680)

    ...

    This issue will close once commit b1c870b is merged into the 'master' branch.

    b1c870b
18. Hixie

    reopened this on Dec 21, 2017
19. Hixie

    closed this as completedon Dec 21, 2017
20. levrik commented on Feb 15, 2018

    

    levrik

    on Feb 15, 2018

    Contributor

    More actions

    @Hixie Was this disabled again on Android? Wanted to propose Flutter for some new project but now I'm not sure anymore if people would be positive about Flutter.
21. Hixie commented on Feb 15, 2018

    

    Hixie

    on Feb 15, 2018

    Contributor

    More actions

    There's a flag you can flip right now to decide if it should be enabled or not:
    MaterialPageRoute.debugEnableFadingRoutes

    It currently defaults to false though we may change it to true in the next few days. We're working on a real fix though to make it fast so we can enable it proudly.

    👍React with 👍7Reacted by Pascal Welsch, Manpreet Singh Matharu, Levin Rickert, Brian Egan, Lukasz Piliszczuk, Izam Basiron and luccascorrea
22. levrik commented on Feb 15, 2018

    

    levrik

    on Feb 15, 2018

    Contributor

    More actions

    @Hixie Thank you! Looking forward to the real fix 🙂
23. sfunke commented on May 9, 2018

    

    sfunke

    on May 9, 2018

    More actions

    No progress on this issue (beta 0.3.2)?
    This is very visible jank and gives a wrong impression of Flutter to potential adopters.
    Setting MaterialPageRoute.debugEnableFadingRoutesto true seems no real solution for production use.

    I propose to reopen, since all linked issues here are closed as well.

    👍React with 👍2Reacted by gcshri and Thomas Quercia
24. eseidelGoogle commented on May 9, 2018

    

    eseidelGoogle

    on May 9, 2018

    Contributor

    More actions

    @xster @Hixie I believe this is still being worked on correct? Is this the right bug to track the work?
25. Hixie commented on May 9, 2018

    

    Hixie

    on May 9, 2018

    Contributor

    More actions

    #13736 is the issue where this is being tracked.
    We currently have multiple engineers focused on fixing the performance issues involved in a fade transition; it is one of our top issues currently.

    👍React with 👍8Reacted by Levin Rickert, Niklas, Rasmus Brinck, gcshri, luccascorrea, Rahul, Itay Ganor and vishal sharma
26. DaveShuckerow

    added 2 commits that reference this issue on May 14, 2018

    Reenable fade transition for Material page transition (flutter#13048)

    ...

    This issue will close once commit a59ea68 is merged into the 'master' branch.

    a59ea68

    Reenable fade transition for Material page transition (flutter#13048) (…

    ...

    This issue will close once commit f4ae323 is merged into the 'master' branch.

    f4ae323
27. github-actions commented on Aug 16, 2021

    

    github-actionsBot

    on Aug 16, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
28. github-actions

    locked as resolved and limited conversation to collaborators on Aug 16, 2021