Skip to content

Engine failing to roll to Framework on dart fix test errors #128527

@zanderso

Description

@zanderso

Started following the Dart -> Engine roll here flutter/engine#42657

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20framework_tests_slow/12784/overview

Failed when applying fixes to /b/s/w/ir/x/w/flutter/packages/flutter_test/test_fixes/flutter_test/binding/live_test_widgets_flutter_binding.dart
Expected:
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter_test/flutter_test.dart';

void main() {
  final binding = LiveTestWidgetsFlutterBinding.ensureInitialized();
  binding.runTest(
    () async { },
    () { },
  );
}


Actual (original code was unchanged):
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter_test/flutter_test.dart';

void main() {
  final binding = LiveTestWidgetsFlutterBinding.ensureInitialized();
  binding.runTest(
    () async { },
    () { },
    // Changes made in https://github.com/flutter/flutter/pull/89952
    timeout: Duration(minutes: 30),
  );
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressiondependency: dartDart team may need to help usframeworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions