-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: solvedIssue is closed as solvedIssue is closed as solvedteam-engineOwned by Engine teamOwned by Engine teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-engineTriaged by Engine teamTriaged by Engine team
Description
I'm on flutter/engine@b4fb112 which pulls dart-lang/sdk@1618a77
I need to modify the Dart SDK, and would like to do so in a Flutter Engine development environment (on iOS). I have my changes working in the Dart VM locally (outside of Flutter). I was having trouble, so I tried to just build "stable" (before yesterday's release).
But I can't get it to build clean from a stock setup. Am I holding it wrong?
eseidel@erics-mbp src % ./flutter/tools/gn --no-goma --unoptimized --no-prebuilt-dart-sdk
Generating GN files in: out/host_debug_unopt
WARNING at the command-line "--args":1:1103: Build argument has no effect.
is_debug=true use_goma=false goma_dir="None" full_dart_sdk=false skia_enable_flutter_defines=true skia_use_dng_sdk=false skia_use_sfntly=false skia_enable_pdf=false skia_use_x11=false skia_use_wuffs=true skia_use_expat=false skia_use_fontconfig=false skia_use_legacy_layer_bounds=true skia_use_icu=true is_official_build=true android_full_debug=false is_clang=true skia_gl_standard="" use_clang_static_analyzer=false enable_coverage=false enable_lto=false host_os="mac" host_cpu="x64" target_os="mac" target_cpu="x64" dart_target_arch="x64" mac_sdk_min="10.14" mac_deployment_target="10.14.0" use_ios_simulator=false flutter_use_fontconfig=false dart_component_kind="static_library" embedder_for_target=false dart_lib_export_symbols=false flutter_runtime_mode="debug" dart_version_git_info=true dart_runtime_mode="develop" dart_include_wasm_opt=false enable_desktop_embeddings=true bssl_use_clang_integrated_as=true skia_use_gl=true allow_deprecated_api_calls=true skia_use_metal=true shell_enable_metal=true disable_hidden_visibility=false dart_platform_sdk=true stripped_symbols=true angle_build_all=false angle_has_astc_encoder=false angle_use_x11=false angle_use_wayland=false angle_enable_vulkan_validation_layers=false angle_vulkan_headers_dir="//third_party/vulkan-deps/vulkan-headers/src" angle_vulkan_loader_dir="//third_party/vulkan-deps/vulkan-loader/src" angle_vulkan_tools_dir="//third_party/vulkan-deps/vulkan-tools/src"
^----
The variable "angle_build_all" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
To view all possible args, run "gn args --list <out_dir>"
The build continued as if that argument was unspecified.
Generating Xcode projects took 176ms
Generating compile_commands took 44ms
Done. Made 1203 targets from 325 files in 2480ms
eseidel@erics-mbp src % ninja -C out/host_debug_unopt
ninja: Entering directory `out/host_debug_unopt'
[0/1] Regenerating ninja files
WARNING at build arg file (use "gn args <out_dir>" to edit):47:19: Build argument has no effect.
angle_build_all = false
^----
The variable "angle_build_all" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
To view all possible args, run "gn args --list <out_dir>"
The build continued as if that argument was unspecified.
[259/2055] ACTION //third_party/dart/utils/analysis_server:analysis_server_dill(//build/toolchain/mac:clang_x64)
FAILED: gen/third_party/dart/utils/analysis_server/analysis_server.dart.dill
vpython3 ../../third_party/dart/build/gn_run_binary.py compiled_action ../../third_party/dart/tools/sdks/dart-sdk/bin/dart -Dsdk_hash=1618a77599 --dfe=../../third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot gen/third_party/dart/utils/gen_kernel/bootstrap_gen_kernel.dill --packages=../../third_party/dart/.dart_tool/package_config.json --platform=vm_platform_strong.dill --no-aot --no-embed-sources --no-link-platform --output=gen/third_party/dart/utils/analysis_server/analysis_server.dart.dill --depfile=gen/third_party/dart/utils/analysis_server/analysis_server.dart.dill.d -Dsdk_hash=1618a77599 -Ddart.vm.product=false ../../third_party/dart/pkg/analysis_server/bin/server.dart
Command failed: /Users/eseidel/Documents/GitHub/ios_engine/src/third_party/dart/tools/sdks/dart-sdk/bin/dart -Dsdk_hash=1618a77599 --dfe=../../third_party/dart/tools/sdks/dart-sdk/bin/snapshots/kernel-service.dart.snapshot gen/third_party/dart/utils/gen_kernel/bootstrap_gen_kernel.dill --packages=../../third_party/dart/.dart_tool/package_config.json --platform=vm_platform_strong.dill --no-aot --no-embed-sources --no-link-platform --output=gen/third_party/dart/utils/analysis_server/analysis_server.dart.dill --depfile=gen/third_party/dart/utils/analysis_server/analysis_server.dart.dill.d -Dsdk_hash=1618a77599 -Ddart.vm.product=false ../../third_party/dart/pkg/analysis_server/bin/server.dart
output: ../../third_party/dart/pkg/analysis_server/lib/src/analytics/noop_analytics.dart:18:15: Error: Type 'ToolInfo' not found.
Map<String, ToolInfo> get parsedTools => throw UnimplementedError();
^^^^^^^^
../../third_party/dart/pkg/analysis_server/lib/src/server/driver.dart:241:41: Error: The getter 'okToSend' isn't defined for the class 'Analytics'.
- 'Analytics' is from 'package:unified_analytics/src/analytics.dart' ('../../third_party/dart/third_party/pkg/tools/pkgs/unified_analytics/lib/src/analytics.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'okToSend'.
return analyticsManager.analytics.okToSend;
^^^^^^^^
[272/2055] CXX obj/third_party/vulkan-deps/spirv-cross/src/spirv_cross_flutter.spirv_msl.o
ninja: build stopped: subcommand failed.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.r: solvedIssue is closed as solvedIssue is closed as solvedteam-engineOwned by Engine teamOwned by Engine teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-engineTriaged by Engine teamTriaged by Engine team