Skip to content

google_signin plugin crashes app if plist.info is incorrectly configured #12734

@mit-mit

Description

@mit-mit

Steps to Reproduce

  1. Follow the first six steps of https://codelabs.developers.google.com/codelabs/flutter-firebase/
  2. Mess up on the step to add <key>CFBundleURLTypes</key>, for example paste it at the wrong location in the XML tree
  3. Run app

=> the app crashes:

Syncing files to device iPhone X...                   1.0s

🔥  To hot reload your app on the fly, press "r". To restart the app entirely, press "R".
An Observatory debugger and profiler on iPhone X is available at: http://127.0.0.1:8112/
For a more detailed help message, press "h". To quit, press "q".
[Firebase/Analytics][I-ACS032003] iAd framework is not linked. Search Ad Attribution Reporter is disabled.
[Firebase/Analytics][I-ACS023012] Firebase Analytics enabled
)
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010d12d1cb __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x00000001120cbf41 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010d1a1b95 +[NSException raise:format:] + 197
	3   Runner                              0x000000010c062681 -[GIDSignIn signInWithOptions:] + 242
	4   Runner                              0x000000010c05f06d -[GIDSignIn signIn] + 64
	5   Runner                              0x000000010befa555 -[GoogleSignInPlugin handleMethodCall:result:] + 1461
	6   Flutter                             0x000000010d9fe9b1 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 118
	7   Flutter                             0x000000010da11667 _ZN5shell15P<…>
Lost connection to device.

Can we fail more graciously?

Metadata

Metadata

Assignees

Labels

c: crashStack traces logged to the consolep: google_sign_inThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions