[Impeller] MaskFilter not applied when using Shader (in CustomPainter) #127013
Description
Is there an existing issue for this?
- I have searched the existing issues
- I have read the guide to filing a bug
Steps to reproduce
CustomPainter with a Paint using a shader (e.g. based on LinearGradient) and a maskFilter (blur). The maskFilter is not applied in Impeller.
Note: when not using a shader (i.e. only a color for the paint) it works as expected (blur applied)
Expected results
Blur should be applied on top of the shader
See how it looks in Skia
Actual results
Mask Filter not applied
Code sample
Code sample
import 'package:flutter/material.dart';
import 'dart:math' as math;
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(scaffoldBackgroundColor: Colors.grey.shade900),
home: const Scaffold(
body: Center(
child: SizedBox(
height: 250,
width: 250,
child: CustomPaint(
painter: _InconsistentRenderingExample(),
),
),
),
),
);
}
}
class _InconsistentRenderingExample extends CustomPainter {
const _InconsistentRenderingExample();
@override
void paint(Canvas canvas, Size size) {
final center = Offset(size.width / 2, size.height / 2);
final rect = Rect.fromCenter(center: center, width: size.width, height: size.height);
final shader = const LinearGradient(
begin: Alignment.topLeft,
end: Alignment.bottomRight,
colors: [Colors.amber, Colors.red],
stops: [0.0, 0.66],
).createShader(rect);
var color = Paint()
..maskFilter = const MaskFilter.blur(BlurStyle.normal, 12)
..shader = shader // Impeller ignores maskFilter when using shader
// ..color = Colors.amber // with color instead of shader, Impeller and Skia both blur
..strokeWidth = 12
..style = PaintingStyle.stroke;
canvas.drawArc(rect, 0, math.pi * 2, false, color);
}
@override
bool shouldRepaint(covariant _InconsistentRenderingExample oldDelegate) => true;
}Screenshots or Video
Screenshots
Skia (expected)
Impeller (incorrect)
Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.10.0, on macOS 13.3.1 22E772610a darwin-arm64, locale en-AT)
• Flutter version 3.10.0 on channel stable at /Users/florian/Developer/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 84a1e904f4 (8 days ago), 2023-05-09 07:41:44 -0700
• Engine revision d44b5a94c9
• Dart version 3.0.0
• DevTools version 2.23.1
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at /Users/florian/Library/Android/sdk
✗ cmdline-tools component is missing
Run `path/to/sdkmanager --install "cmdline-tools;latest"`
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run `flutter doctor --android-licenses` to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E222b
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
[✓] VS Code (version 1.78.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.64.0
[✓] Connected device (3 available)
• iPhone 14 Pro Max (mobile) • 938B169D-E0C3-4790-BD18-75AD09E2F016 • ios • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
• macOS (desktop) • macos • darwin-arm64 • macOS 13.3.1 22E772610a darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 113.0.5672.126
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.Metadata
Metadata
Assignees
Labels
Important issues not at the top of the work listImpeller rendering backend issues and features requestsflutter/engine related. See also e: labels.Found to occur in 3.10Found to occur in 3.11The issue has been confirmed reproducible and is ready to work oniOS applications specificallyIssue is closed as already fixed in a newer version