Skip to content

Add tests for Material 3 Date pickers #126826

@TahaTesser

Description

@TahaTesser

Is there an existing issue for this?

Steps to reproduce

While working on some other M3 date picker issues like #126597, I noticed the M3 layout and config changes made in #119033 aren't tested in date_picker_test.dart.

https://github.com/flutter/flutter/pull/119033/files#diff-198d5dd0fe89bb71e1940816baf20e7b57ee896ed31120b7c3fcebcc4ac3bfbe has a bunch of changes in date_picker.dart and most of these changes aren't tested in date_picker_test.dart.

Screenshot 2023-05-15 at 17 18 32

Expected results

date_picker_test.dart has M3 test coverage

Actual results

Most of the M3 changes aren't tested and modifying some M3 defaults or removing M3-related widgets from date_picker.test doesn't fail tests in the date_picker_test.dart class.
Screenshot 2023-05-15 at 17 28 13

Code sample

~

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
[Paste your output here]

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsf: date/time pickerDate or time picker widgetsf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions