Skip to content

Drop support for reusing DisplayListBuilder after calling Build #126589

@flar

Description

@flar

For now, unit tests are attempting to reuse an existing DisplayListBuilder after they Build a DisplayList from it as they were written that way using MockCanvas. This is a really muddy way to perform the tests and doesn't match the way that the builders are used in real-world code. Additionally, there is a bunch of code in Build() right now to make that possible that we really shouldn't need.

DisplayListBuilder should be re-spec'd to not allow use after Build and we should adjust the tests accordingly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Status

    🛠️ Internals

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions